-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include freetype source from openjdk #631
Conversation
jenkins test sanity aix,alinux64,osx,win,win32 jdk8 depends eclipse-openj9/openj9#16182 |
Build dependency doesn't seem to have had the desired affect on configure options; trying macOS & Windows in eclipse-openj9/openj9#16182. |
We'll need to modify https://github.com/ibmruntimes/temurin-build/ concurrently as well or the Semeru builds will break. |
Like jdk11+, we can use |
Updated |
See these pull requests: |
Ok. Now we need to wait for the 0.35 build to be finalized so these changes don't break those builds. |
@keithc-ca do you intend to upstream this to mainstream OpenJDK8 development? It's something the updates project have been hoping to do for some time. |
It would seem a reasonable course of action; I'll see if I can find some help to make that happen. |
Sounds good, more than happy to help @keithc-ca |
* remove '--with-freetype-src' configure option Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Rebased and updated to reflect licence changes in ibmruntimes/openj9-openjdk-jdk11@1f8e807. |
What version of Freetype is this src ? |
2.12.1 Same as used by jdk11, 17, 19+ |
@gdams Do you have a link to updates maillist discussions on this? thanks |
@andrew-m-leonard see the discussion in openjdk/jdk8u-dev#3 (comment) |
It would definitely be good to see this upstream and should allow us to remove the need to build FreeType within the GitHub Actions for Windows. I think this would primarily be a backport of JDK-8193017, though we can reference further bugs to note that we also have updates to later versions. A PR with the subject |
freetype is automatically include in jdk8 builds since ibmruntimes/openj9-openjdk-jdk8#631 Obsoletes eclipse-openj9#17329 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
As nobody has picked this up yet I'll have a go at the backport process to jdk8u-dev |
freetype is automatically include in jdk8 builds since ibmruntimes/openj9-openjdk-jdk8#631 Obsoletes eclipse-openj9#17329 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
freetype is automatically include in jdk8 builds since ibmruntimes/openj9-openjdk-jdk8#631 Obsoletes eclipse-openj9#17329 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
--with-freetype-src
configure option--with-free-type=
accepts onlybundled
orsystem
, consistent with other versionsMust be merge concurrently with eclipse-openj9/openj9#16182.